Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 12566035: Added survey butter-bar to web-app. (Closed)

Created:
7 years, 9 months ago by Jamie
Modified:
7 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Added survey butter-bar to web-app. The butter-bar is shown until the user either closes it with the X icon or begins the survey. Once dismissed, a cookie is stored in sync storage to prevent it showing up again for that user on another computer (note that this uses Chrome Sync, so it relies on them being signed in to Chrome). BUG=191368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189854

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed typos. #

Patch Set 3 : Rebase #

Patch Set 4 : Improved string grammar. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -10 lines) Patch
M remoting/remoting.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M remoting/webapp/all_js_load.gtestjs View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/appsv2.patch View 5 chunks +6 lines, -6 lines 0 comments Download
M remoting/webapp/jscompiler_hacks.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/webapp/main.css View 1 chunk +39 lines, -0 lines 0 comments Download
M remoting/webapp/main.html View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M remoting/webapp/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/remoting.js View 1 3 chunks +7 lines, -4 lines 0 comments Download
A remoting/webapp/survey.js View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jamie
ptal https://codereview.chromium.org/12566035/diff/1/remoting/webapp/survey.js File remoting/webapp/survey.js (right): https://codereview.chromium.org/12566035/diff/1/remoting/webapp/survey.js#newcode36 remoting/webapp/survey.js:36: }; Is there anything else you'd like to ...
7 years, 9 months ago (2013-03-20 00:32:52 UTC) #1
garykac
lgtm https://codereview.chromium.org/12566035/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/12566035/diff/1/remoting/resources/remoting_strings.grd#newcode196 remoting/resources/remoting_strings.grd:196: <message desc="Invitation to the user to participate in ...
7 years, 9 months ago (2013-03-20 20:51:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12566035/7001
7 years, 9 months ago (2013-03-21 17:19:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12566035/25001
7 years, 9 months ago (2013-03-21 17:45:16 UTC) #4
Jamie
Committed patchset #4 manually as r189854 (presubmit successful).
7 years, 9 months ago (2013-03-22 18:16:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12566035/25001
7 years, 9 months ago (2013-03-22 18:22:28 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-22 18:22:34 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for remoting/remoting.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file remoting/remoting.gyp
  Hunk #1 FAILED at 206.
  1 out of 1 hunk FAILED -- saving rejects to file remoting/remoting.gyp.rej

Patch:       remoting/remoting.gyp
Index: remoting/remoting.gyp
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp
index
4105bfe37d7e77fd2e9f53769f96e9e4d17313ab..2349ef4f56ccecb9b6d6f3decd5fe6c251831fa0
100644
--- a/remoting/remoting.gyp
+++ b/remoting/remoting.gyp
@@ -206,6 +206,7 @@
       'webapp/server_log_entry.js',
       'webapp/stats_accumulator.js',
       'webapp/storage.js',
+      'webapp/survey.js',
       'webapp/toolbar.js',
       'webapp/ui_mode.js',
       'webapp/wcs.js',

Powered by Google App Engine
This is Rietveld 408576698