Try to track down a dangling ClientSocketHandle* by upgrading DCHECKs to CHECKs.

Try to track down a dangling ClientSocketHandle* by upgrading DCHECKs to CHECKs.
Add exception handling code for GetLoadState() for when a ClientSocketHandle doesn't exist.
BUG=http://crbug.com/13908

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18242

[willchan no longer on Chromium, 2009-06-11 23:54:16]

I looked at this crash and it seems like we're trying to GetLoadState() for a
ClientSocketHandle* that TCPClientSocketPool doesn't recognize.  I added
exception handling code to handle this gracefully in releases, but we're
probably reaching this due to a bug elsewhere, so I'm upgrading the DCHECKs to
CHECKs to see if I can catch any inconsistency elsewhere.

[wtc, 2009-06-11 23:58:19]

LGTM.  Hope you can track this down soon.

http://codereview.chromium.org/125025/diff/1/3
File net/base/tcp_client_socket_pool.cc (right):

http://codereview.chromium.org/125025/diff/1/3#newcode310
Line 310: NOTREACHED() << "ClientSocketPool does not contain group: " <<
group_name
NOTREACHED is a DCHECK.

[willchan no longer on Chromium, 2009-06-12 00:23:54]

http://codereview.chromium.org/125025/diff/1/3
File net/base/tcp_client_socket_pool.cc (right):

http://codereview.chromium.org/125025/diff/1/3#newcode310
Line 310: NOTREACHED() << "ClientSocketPool does not contain group: " <<
group_name
On 2009/06/11 23:58:19, wtc wrote:
> NOTREACHED is a DCHECK.

i know it's a DCHECK.  i want to keep it as a DCHECK, but not crash in that one
particular spot in release, just in case i am wrong and the other CHECKs don't
catch it.