Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: net/base/client_socket_handle.cc

Issue 125025: Try to track down a dangling ClientSocketHandle* by upgrading DCHECKs to CHECKs. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/tcp_client_socket_pool.cc » ('j') | net/base/tcp_client_socket_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/client_socket_handle.cc
diff --git a/net/base/client_socket_handle.cc b/net/base/client_socket_handle.cc
index 81841fa0e6545fe8ae1fc53db9f0dd5464d78e64..043cefd88cee4ca4eab0169f38f70a1744dc571f 100644
--- a/net/base/client_socket_handle.cc
+++ b/net/base/client_socket_handle.cc
@@ -57,13 +57,13 @@ void ClientSocketHandle::ResetInternal(bool cancel) {
}
LoadState ClientSocketHandle::GetLoadState() const {
- DCHECK(!is_initialized());
- DCHECK(!group_name_.empty());
+ CHECK(!is_initialized());
+ CHECK(!group_name_.empty());
return pool_->GetLoadState(group_name_, this);
}
void ClientSocketHandle::OnIOComplete(int result) {
- DCHECK_NE(ERR_IO_PENDING, result);
+ CHECK(ERR_IO_PENDING != result);
CompletionCallback* callback = user_callback_;
user_callback_ = NULL;
if (result != OK)
« no previous file with comments | « no previous file | net/base/tcp_client_socket_pool.cc » ('j') | net/base/tcp_client_socket_pool.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698