Issue 1247004: Revert 42474 - Make repost form warning tabmodal on Gtk....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247004: Revert 42474 - Make repost form warning tabmodal on Gtk.... (Closed)

Created:
10 years, 9 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 42474 - Make repost form warning tabmodal on Gtk. This is the Gtk version of http://codereview.chromium.org/969003. BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perlcgi/programs/form1POST.html, hit Submit, then refresh. The warning sheet should be tabmodal, not windowmodal. Opening a login form (which is also tabmodal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/660434 TBR=bauerb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42479

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -102 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/repost_form_warning_gtk.h	View	3 chunks	+8 lines, -21 lines	0 comments	Download
M	chrome/browser/gtk/repost_form_warning_gtk.cc	View	3 chunks	+37 lines, -76 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)