Make repost form warning tab-modal on Gtk.

Make repost form warning tab-modal on Gtk.

This is the Gtk version of http://codereview.chromium.org/969003. 

BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should bringing up the warning while a login form is shown.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42474

[Bernhard Bauer, 2010-03-03 03:43:13]

http://codereview.chromium.org/660434/diff/1/3
File chrome/browser/gtk/repost_form_warning_gtk.cc (right):

http://codereview.chromium.org/660434/diff/1/3#newcode57
chrome/browser/gtk/repost_form_warning_gtk.cc:57: // TODO(bauerb) keyboard
shortcuts don't work
@evan: Do you know what I should do here? In the login form, escape cancels the
dialog, and enter submits it.

[Evan Martin, 2010-03-03 14:56:13]

+erg, tab-modal master

[Elliot Glaysher, 2010-03-03 18:40:17]

LGTM, with fixes to keyboard shortcuts.

http://codereview.chromium.org/660434/diff/1/3
File chrome/browser/gtk/repost_form_warning_gtk.cc (right):

http://codereview.chromium.org/660434/diff/1/3#newcode57
chrome/browser/gtk/repost_form_warning_gtk.cc:57: // TODO(bauerb) keyboard
shortcuts don't work
On 2010/03/03 03:43:13, bernhard wrote:
> @evan: Do you know what I should do here? In the login form, escape cancels
the
> dialog, and enter submits it.

I would guess that you're not getting keyboard shortcuts because you're not
building your buttons from stock. Use
gtk_button_new_from_stock(GTK_STOCK_REFRESH), or the equivalent of whats behind
gtk_util::AddButtonToDialog() if you want our string instead and it should work
(along with auto-following the HIG).

[Bernhard Bauer, 2010-03-15 20:13:50]

I changed the callbacks to use the CHROMEGTK_CALLBACK_\d macros. erg, could you
take another look?

http://codereview.chromium.org/660434/diff/9001/10002
File chrome/browser/gtk/repost_form_warning_gtk.cc (right):

http://codereview.chromium.org/660434/diff/9001/10002#newcode17
chrome/browser/gtk/repost_form_warning_gtk.cc:17: G_CALLBACK(METHOD ## Thunk)
I added this so I don't have to write |Thunk| in the code (when there is nothing
about a |Thunk| in the header file). Do you think I should put this into a
header somewhere?

[Evan Martin, 2010-03-15 20:15:49]

http://codereview.chromium.org/660434/diff/9001/10002
File chrome/browser/gtk/repost_form_warning_gtk.cc (right):

http://codereview.chromium.org/660434/diff/9001/10002#newcode17
chrome/browser/gtk/repost_form_warning_gtk.cc:17: G_CALLBACK(METHOD ## Thunk)
On 2010/03/15 20:13:50, bernhard wrote:
> I added this so I don't have to write |Thunk| in the code (when there is
nothing
> about a |Thunk| in the header file). Do you think I should put this into a
> header somewhere? 

Heh, Elliot had this in the original header when he added this stuff.  estade
and I countered that each macro we add harms readability; the "Thunk" think
isn't so bad as it's checked at compile time.

[Bernhard Bauer, 2010-03-15 20:30:11]

http://codereview.chromium.org/660434/diff/9001/10002
File chrome/browser/gtk/repost_form_warning_gtk.cc (right):

http://codereview.chromium.org/660434/diff/9001/10002#newcode17
chrome/browser/gtk/repost_form_warning_gtk.cc:17: G_CALLBACK(METHOD ## Thunk)
Hm, I added the macro exactly because of readability, because it's hard to know
where an |OnSomethingThunk| comes from when it's not defined in the header,
without knowing how the CHROMEGTK_CALLBACK_\d macros work.

But if you want me to remove it, that's fine with me too.

[Elliot Glaysher, 2010-03-16 05:23:15]

For the record, I disagree with the Evans.

While humans know about "Thunk", editors don't. And in the interceding
few days, I've tried to go to the definition of OnSomethingThunk
(which obviously doesn't exist) in a file; I used to navigate to the
individual functions with C-s C-w C-s from the signal definitions and
now that's broken :(

[Bernhard Bauer, 2010-03-18 01:25:21]

Unless there are objections, I'm going to land this with |G_CALLBACK| and
|Thunk|s soon-ish (but +1 for adding something similar globally).