Add Geolocation to the content types. This adds several special case guards s...

Add Geolocation to the content types. This adds several special case guards so we can still build & run whilst the full implementation is being worked on (in parallel)

(Some code taken from http://codereview.chromium.org/650180)

BUG=11246
TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42633

[joth, 2010-03-25 16:55:21]

This looks sound enough to land, once it's in we can start working in parallel
on remaining bits.

[bulach, 2010-03-25 17:15:46]

LGTM

ugly but necessary.. :( too bad we didn't go ahead with that (big) change of
mine... oh, well..

http://codereview.chromium.org/1241006/diff/24001/25005
File chrome/browser/content_setting_bubble_model.h (right):

http://codereview.chromium.org/1241006/diff/24001/25005#newcode58
chrome/browser/content_setting_bubble_model.h:58: std::vector<DomainList>
domain_lists;
revert this file?

[joth, 2010-03-25 17:30:39]

On 2010/03/25 17:15:46, bulach wrote:
> LGTM
> 
Thanks, will commit now so we can get on fixing it up.

> ugly but necessary.. :( too bad we didn't go ahead with that (big) change of
> mine... oh, well..
> 
yeah, but small is beautiful eh?

> http://codereview.chromium.org/1241006/diff/24001/25005
> File chrome/browser/content_setting_bubble_model.h (right):
> 
> http://codereview.chromium.org/1241006/diff/24001/25005#newcode58
> chrome/browser/content_setting_bubble_model.h:58: std::vector<DomainList>
> domain_lists;
> revert this file?

Good spot, done.