chrome/browser/tab_contents/tab_contents.cc - Issue 1241006: Add Geolocation to the content types. This adds several special case guards s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 1241006: Add Geolocation to the content types. This adds several special case guards s... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/gtk/options/content_settings_window_gtk.cc ('k') | chrome/browser/views/options/content_settings_window_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/tab_contents.cc

===================================================================

--- chrome/browser/tab_contents/tab_contents.cc (revision 42594)

+++ chrome/browser/tab_contents/tab_contents.cc (working copy)

@@ -622,6 +622,10 @@

content_type == CONTENT_SETTINGS_TYPE_COOKIES)

return content_blocked_[content_type];

+ // TODO(joth): remove once fully implemented.

+ if (content_type == CONTENT_SETTINGS_TYPE_GEOLOCATION)

+ return false;

NOTREACHED();

return false;

}

@@ -2030,6 +2034,8 @@

}

void TabContents::OnContentBlocked(ContentSettingsType type) {

+ // TODO(joth): remove once fully implemented.

+ DCHECK(type != CONTENT_SETTINGS_TYPE_GEOLOCATION);

content_blocked_[type] = true;

if (delegate_)

delegate_->OnBlockedContentChange(this);