Add control test for login_CryptohomeMounted

Add control test for login_CryptohomeMounted

When we log in with the localaccount, we should get a tmpfs instead of a cryptohome.  This tests that, and also acts as a control to ensure that we're not returning false positives in the other cryptohome test.

[gauravsh, 2010-03-25 01:40:24]

http://codereview.chromium.org/1234004/diff/1/3
File client/site_tests/login_CryptohomeMounted/control (left):

http://codereview.chromium.org/1234004/diff/1/3#oldcode21
client/site_tests/login_CryptohomeMounted/control:21: #             
is_control=True,
What does the is_control parameter denote?

http://codereview.chromium.org/1234004/diff/1/4
File client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
(right):

http://codereview.chromium.org/1234004/diff/1/4#newcode16
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16: def
run_once(self, script = 'autox_script.json', is_control = False):
Nit: no space around '='

http://codereview.chromium.org/1234004/diff/1/4#newcode24
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:24: if
site_cryptohome.is_mounted(allow_fail = is_control) == is_control:
Nit: no space around '='

[gauravsh, 2010-03-25 01:44:25]

Also, maybe this is an autotest convention, but what does "tag='control'" do?

On Wed, Mar 24, 2010 at 6:40 PM,  <gauravsh@chromium.org> wrote:
>
> http://codereview.chromium.org/1234004/diff/1/3
> File client/site_tests/login_CryptohomeMounted/control (left):
>
> http://codereview.chromium.org/1234004/diff/1/3#oldcode21
> client/site_tests/login_CryptohomeMounted/control:21: #
> is_control=True,
> What does the is_control parameter denote?
>
> http://codereview.chromium.org/1234004/diff/1/4
> File
> client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
> (right):
>
> http://codereview.chromium.org/1234004/diff/1/4#newcode16
> client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16:
> def run_once(self, script = 'autox_script.json', is_control = False):
> Nit: no space around '='
>
> http://codereview.chromium.org/1234004/diff/1/4#newcode24
> client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:24:
> if site_cryptohome.is_mounted(allow_fail = is_control) == is_control:
> Nit: no space around '='
>
> http://codereview.chromium.org/1234004
>



-- 
-g

[Chris Masone, 2010-03-25 03:33:16]

and, the "tag" arg is an autotest convention that allows you to label tests that
are parameterized variants of one another.

http://codereview.chromium.org/1234004/diff/1/3
File client/site_tests/login_CryptohomeMounted/control (left):

http://codereview.chromium.org/1234004/diff/1/3#oldcode21
client/site_tests/login_CryptohomeMounted/control:21: #             
is_control=True,
That this test is the control, in the scientific sense.

On 2010/03/25 01:40:32, gauravsh wrote:
> What does the is_control parameter denote?

http://codereview.chromium.org/1234004/diff/1/4
File client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
(right):

http://codereview.chromium.org/1234004/diff/1/4#newcode16
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16: def
run_once(self, script = 'autox_script.json', is_control = False):
On 2010/03/25 01:40:32, gauravsh wrote:
> Nit: no space around '='

I was explicitly told to put those there by sosa.

[gauravsh, 2010-03-25 03:46:58]

LGTM once you fix the spacing issue or alternatively show that my understanding
iis wrong. :)

http://codereview.chromium.org/1234004/diff/1/4
File client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
(right):

http://codereview.chromium.org/1234004/diff/1/4#newcode16
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16: def
run_once(self, script = 'autox_script.json', is_control = False):
On 2010/03/25 03:33:16, cmasone wrote:
> On 2010/03/25 01:40:32, gauravsh wrote:
> > Nit: no space around '='
> 
> I was explicitly told to put those there by sosa.

Python style guide says no spaces around keyword arguments or when default
parameter values are specified.

http://codereview.chromium.org/1234004/diff/1/4#newcode24
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:24: if
site_cryptohome.is_mounted(allow_fail = is_control) == is_control:
It took me a few moments to parse if this is the correct logic. Maybe something
like: 
if !is_control && !site_cryptohome.is_mounted(....) would be clearer. Or a
simple comment. Your call if you want to keep it as is though.

[Chris Masone, 2010-03-25 04:26:18]

On 2010/03/25 03:46:58, gauravsh wrote:
> LGTM once you fix the spacing issue or alternatively show that my
understanding
> iis wrong. :)

I am monumentally indifferent to this spacing issue.  Sosa, what's the deal with
this?

> 
> http://codereview.chromium.org/1234004/diff/1/4
> File client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
> (right):
> 
> http://codereview.chromium.org/1234004/diff/1/4#newcode16
> client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16: def
> run_once(self, script = 'autox_script.json', is_control = False):
> On 2010/03/25 03:33:16, cmasone wrote:
> > On 2010/03/25 01:40:32, gauravsh wrote:
> > > Nit: no space around '='
> > 
> > I was explicitly told to put those there by sosa.
> 
> Python style guide says no spaces around keyword arguments or when default
> parameter values are specified.
> 
> http://codereview.chromium.org/1234004/diff/1/4#newcode24
> client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:24: if
> site_cryptohome.is_mounted(allow_fail = is_control) == is_control:
> It took me a few moments to parse if this is the correct logic. Maybe
something
> like: 
> if !is_control && !site_cryptohome.is_mounted(....) would be clearer. Or a
> simple comment. Your call if you want to keep it as is though.

[petkov, 2010-03-25 04:58:21]

http://codereview.chromium.org/1234004/diff/1/4
File client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
(right):

http://codereview.chromium.org/1234004/diff/1/4#newcode16
client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py:16: def
run_once(self, script = 'autox_script.json', is_control = False):
On 2010/03/25 03:46:58, gauravsh wrote:
> On 2010/03/25 03:33:16, cmasone wrote:
> > On 2010/03/25 01:40:32, gauravsh wrote:
> > > Nit: no space around '='
> > 
> > I was explicitly told to put those there by sosa.
> 
> Python style guide says no spaces around keyword arguments or when default
> parameter values are specified. 

In case there's confusion -- per PEP-8, referenced by local CODING_STYLE, no
spaces around = for default parameter values and keyword arguments... Spaces
around = pretty much everywhere else.