Issue 1234002: Make update_expecations_from_dashboard unit tests pass again....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234002: Make update_expecations_from_dashboard unit tests pass again.... (Closed)

Created:
10 years, 9 months ago by Julie Parent

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make update_expecations_from_dashboard unit tests pass again. 1. Pass expecations into _get_iterable_expectations (this changed at some point and all usages weren't updated). 2. Change unit test expected results to strip out whitespace. Code appearantly changed to strip whitespace at some point, which seems fine. 3. Change unit test expected results to include extra new lines. This seems questionable, but we'll see if this is an issue in practice and address it then if it is. TEST=Run update_expectations_from_dashboard_unittest.py BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42693

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
	M	webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard_unittest.py	View	1 2 3	8 chunks	+22 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Julie Parent

10 years, 9 months ago (2010-03-24 18:28:00 UTC) #3

One more change:
port_obj.path_to_expectations_file() ->
port_obj.path_to_test_expectations_file().

This was also changed in upstream version without all usages being changed.

Expand Messages | Collapse Messages

Issue 1234002: Make update_expecations_from_dashboard unit tests pass again.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages