webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py - Issue 1234002: Make update_expecations_from_dashboard unit tests pass again....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py

Issue 1234002: Make update_expecations_from_dashboard unit tests pass again.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py

===================================================================

--- webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py (revision 42683)

+++ webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard.py (working copy)

@@ -323,7 +323,7 @@

comment_lines = []

removed_test_on_previous_line = False

lineno = 0

- for line in self._get_iterable_expectations():

+ for line in self._get_iterable_expectations(self._expectations):

lineno += 1

test, options, expectations = self.parse_expectations_line(line,

lineno)

@@ -489,7 +489,7 @@

updates = simplejson.load(open(sys.argv[1]))

port_obj = get_port()

- path_to_expectations = port_obj.path_to_expectations_file()

+ path_to_expectations = port_obj.path_to_test_expectations_file()

old_expectations = open(path_to_expectations).read()

new_expectations = update_expectations(port_obj, old_expectations, updates)

« no previous file with comments | « no previous file | webkit/tools/layout_tests/webkitpy/layout_tests/update_expectations_from_dashboard_unittest.py » ('j') | no next file with comments »