X64 implementation starts using virtual frame and register allocators.

X64 implementation starts using virtual frame and register allocators.

Committed: http://code.google.com/p/v8/source/detail?r=2146

[Lasse Reichstein, 2009-06-11 13:05:56]

LGTM, to the amount that I understand about virtual frames.

http://codereview.chromium.org/123018/diff/1/4
File src/x64/assembler-x64.cc (left):

http://codereview.chromium.org/123018/diff/1/4#oldcode1698
Line 1698: }
We really should move all these to their appropriate file now.

http://codereview.chromium.org/123018/diff/1/6
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/123018/diff/1/6#newcode971
Line 971: const Operand& dst,
Alignment on last two arguments is off.

http://codereview.chromium.org/123018/diff/1/5
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/123018/diff/1/5#newcode57
Line 57: // Registers live on entry: rsp, rbp, rsi, rdi.
What do the live registers hold? (At least the ones used in this function)

http://codereview.chromium.org/123018/diff/1/5#newcode61
Line 61: // Verify that edi contains a JS function.  The following code
edi -> rdi

[William Hesse, 2009-06-12 13:59:49]

http://codereview.chromium.org/123018/diff/1/4
File src/x64/assembler-x64.cc (left):

http://codereview.chromium.org/123018/diff/1/4#oldcode1698
Line 1698: }
On 2009/06/11 13:05:56, Lasse Reichstein wrote:
> We really should move all these to their appropriate file now.

Moved most of them.  Some of them do not yet have the appropriate files in the
x64 directory.

http://codereview.chromium.org/123018/diff/1/5
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/123018/diff/1/5#newcode57
Line 57: // Registers live on entry: rsp, rbp, rsi, rdi.
On 2009/06/11 13:05:56, Lasse Reichstein wrote:
> What do the live registers hold? (At least the ones used in this function)

Done.

http://codereview.chromium.org/123018/diff/1/5#newcode61
Line 61: // Verify that edi contains a JS function.  The following code
On 2009/06/11 13:05:56, Lasse Reichstein wrote:
> edi -> rdi

Done.