Issue 123017: X64: Create test JS-function and call it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 123017: X64: Create test JS-function and call it. (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Create test JS-function and call it.

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -5 lines)			Patch
M	src/x64/assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+2 lines, -1 line	2 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Small review. The function is called, and returns a value. Also some small bug-fixes.

11 years, 6 months ago (2009-06-11 12:44:38 UTC) #1

William Hesse

LGTM. http://codereview.chromium.org/123017/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/123017/diff/1/4#newcode574 Line 574: __ lea(kScratchRegister, FieldOperand(rax, Code::kHeaderSize)); Can you use ...

11 years, 6 months ago (2009-06-11 13:04:24 UTC) #2

Lasse Reichstein

11 years, 6 months ago (2009-06-11 13:16:05 UTC) #3

http://codereview.chromium.org/123017/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/123017/diff/1/4#newcode574
Line 574: __ lea(kScratchRegister, FieldOperand(rax, Code::kHeaderSize));
I would rather not.
The expected meaning of a Call(Operand) would be to read the memory value
pointed to by Operand and call that. This is really just using
lea(...,Operand(rax. kHeaderSzie)) as a shorthand for adding kHeaderSize to rax.

Expand Messages | Collapse Messages