Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1225003: Fixing build in debug mode. (Closed)

Created:
10 years, 9 months ago by SeRya
Modified:
9 years, 7 months ago
Reviewers:
fschneider, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fixing build in debug mode. Committed: http://code.google.com/p/v8/source/detail?r=4243

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/conversions.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
SeRya
10 years, 9 months ago (2010-03-24 09:31:54 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/1225003/diff/3001/4001 File src/conversions.cc (left): http://codereview.chromium.org/1225003/diff/3001/4001#oldcode298 src/conversions.cc:298: ASSERT(buffer_pos < buffer_size); I would probably have preferred ...
10 years, 9 months ago (2010-03-24 09:44:05 UTC) #2
fschneider
10 years, 9 months ago (2010-03-24 09:54:34 UTC) #3
Why not make those constants buffer_size and  max_significant_digits "static
const"?

Powered by Google App Engine
This is Rietveld 408576698