Issue 1225003: Fixing build in debug mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225003: Fixing build in debug mode. (Closed)

Created:
10 years, 9 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
fschneider, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixing build in debug mode. Committed: http://code.google.com/p/v8/source/detail?r=4243

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/conversions.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/1225003/diff/3001/4001 File src/conversions.cc (left): http://codereview.chromium.org/1225003/diff/3001/4001#oldcode298 src/conversions.cc:298: ASSERT(buffer_pos < buffer_size); I would probably have preferred ...

10 years, 9 months ago (2010-03-24 09:44:05 UTC) #2

fschneider

10 years, 9 months ago (2010-03-24 09:54:34 UTC) #3

Why not make those constants buffer_size and  max_significant_digits "static
const"?

Expand Messages | Collapse Messages

Issue 1225003: Fixing build in debug mode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages