Fixing build in debug mode.

src/conversions.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 277 matching lines @@
     leading_zero = true;
     ++current;
     if (current == end) return 0;
   }
 
   int begin_pos = buffer_pos;
   while ((*current >= '0' && *current <= '9')
          || (*current >= 'a' && *current <= 'f')
          || (*current >= 'A' && *current <= 'F')) {
     if (significant_digits <= max_significant_digits) {
-      ASSERT(buffer_pos < buffer_size);

[Kasper Lund, 2010/03/24 09:44:05]

I would probably have preferred a solution where we could keep bounds checks in
debug mode, but for now this is okay (since we don't have the bounds checks in
the other places).

I would consider rewriting most of this code using a Vector<char> rather than
char*.

       buffer[buffer_pos++] = *current;
       significant_digits++;
     } else {
       insignificant_digits++;
       nonzero_digit_dropped = nonzero_digit_dropped || *current != '0';
     }
     ++current;
     if (current == end) break;
   }
 
@@ skipping 664 matching lines @@
   // Allocate result and fill in the parts.
   StringBuilder builder(result_size + 1);
   builder.AddSubstring(integer_buffer + integer_pos + 1, integer_part_size);
   if (decimal_pos > 0) builder.AddCharacter('.');
   builder.AddSubstring(decimal_buffer, decimal_pos);
   return builder.Finalize();
 }
 
 
 } }  // namespace v8::internal