Issue 122040: Refactor the unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122040: Refactor the unit tests. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Refactor the unit tests to remove a lot of duplicate code. Remove old unused git-cl test files. TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18177

Patch Set 1 #

Patch Set 2 : Removed old unused test files #

Patch Set 3 : even more cleanup #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -396 lines)			Patch
M	tests/__init__.py	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	tests/abandon.sh	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	tests/basic.sh	View		1 chunk	+0 lines, -62 lines	0 comments	Download
M	tests/gcl_unittest.py	View		1 chunk	+4 lines, -17 lines	0 comments	Download
M	tests/gclient_test.py	View	1 2	8 chunks	+27 lines, -117 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		4 chunks	+5 lines, -39 lines	0 comments	Download
M	tests/revert_unittest.py	View		1 chunk	+4 lines, -19 lines	0 comments	Download
M	tests/test-lib.sh	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	tests/trychange_unittest.py	View		1 chunk	+4 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 6 months ago (2009-06-11 18:06:05 UTC) #3

On 2009/06/11 17:55:38, Jói wrote:
> LGTM

Arg, I had forgot the super_mox.py (ok the name could have been better).

See http://src.chromium.org/viewvc/chrome?view=rev&revision=18179

It's mainly everything extracted from __init__.py + some gclient_test.py
functions into a common base class.

Expand Messages | Collapse Messages