Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tests/gcl_unittest.py

Issue 122040: Refactor the unit tests. (Closed)
Patch Set: even more cleanup Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/basic.sh ('k') | tests/gclient_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gcl_unittest.py
diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py
index 1c07de8a61fdbebde6386e503c8835fd507c9374..9489cf4e29b002658c603e8e47f792e08aeec05e 100755
--- a/tests/gcl_unittest.py
+++ b/tests/gcl_unittest.py
@@ -8,33 +8,20 @@
import unittest
# Local imports
-import __init__
import gcl
-mox = __init__.mox
+import super_mox
+from super_mox import mox
-class GclTestsBase(mox.MoxTestBase):
+class GclTestsBase(super_mox.SuperMoxTestBase):
"""Setups and tear downs the mocks but doesn't test anything as-is."""
def setUp(self):
- mox.MoxTestBase.setUp(self)
+ super_mox.SuperMoxTestBase.setUp(self)
self.mox.StubOutWithMock(gcl, 'RunShell')
self.mox.StubOutWithMock(gcl.gclient, 'CaptureSVNInfo')
self.mox.StubOutWithMock(gcl, 'os')
self.mox.StubOutWithMock(gcl.os, 'getcwd')
- def compareMembers(self, object, members):
- """If you add a member, be sure to add the relevant test!"""
- # Skip over members starting with '_' since they are usually not meant to
- # be for public use.
- actual_members = [x for x in sorted(dir(object))
- if not x.startswith('_')]
- expected_members = sorted(members)
- if actual_members != expected_members:
- diff = ([i for i in actual_members if i not in expected_members] +
- [i for i in expected_members if i not in actual_members])
- print diff
- self.assertEqual(actual_members, expected_members)
-
class GclUnittest(GclTestsBase):
"""General gcl.py tests."""
« no previous file with comments | « tests/basic.sh ('k') | tests/gclient_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698