Issue 122038: Lars spotted that Handle::operator -> and * are not inlined. That apparently...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122038: Lars spotted that Handle::operator -> and * are not inlined. That apparently... (Closed)

Created:
11 years, 6 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Lars spotted that Handle::operator -> and * are not inlined. That apparently buys us almost ~10% speedup for some DOM operations. Committed: http://code.google.com/p/v8/source/detail?r=2148

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -14 lines)			Patch
	M	include/v8.h	View		2 chunks	+6 lines, -14 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/122038/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/122038/diff/1/2#newcode215 Line 215: T* operator->() const { I would write ...

11 years, 6 months ago (2009-06-11 14:51:30 UTC) #3

antonm

11 years, 6 months ago (2009-06-11 19:40:47 UTC) #4

tnx for review!  submitting.

http://codereview.chromium.org/122038/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/122038/diff/1/2#newcode215
Line 215: T* operator->() const {
On 2009/06/11 14:51:30, Kasper Lund wrote:
> I would write this on a single line just like the IsEmpty case.

Done.

http://codereview.chromium.org/122038/diff/1/2#newcode219
Line 219: T* operator*() const {
On 2009/06/11 14:51:30, Kasper Lund wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages