Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: include/v8.h

Issue 122038: Lars spotted that Handle::operator -> and * are not inlined. That apparently... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
===================================================================
--- include/v8.h (revision 2127)
+++ include/v8.h (working copy)
@@ -212,9 +212,13 @@
*/
bool IsEmpty() const { return val_ == 0; }
- T* operator->() const;
+ T* operator->() const {
Kasper Lund 2009/06/11 14:51:30 I would write this on a single line just like the
antonm 2009/06/11 19:40:47 Done.
+ return val_;
+ }
- T* operator*() const;
+ T* operator*() const {
Kasper Lund 2009/06/11 14:51:30 Ditto.
antonm 2009/06/11 19:40:47 Done.
+ return val_;
+ }
/**
* Sets the handle to be empty. IsEmpty() will then return true.
@@ -2509,18 +2513,6 @@
V8::ClearWeak(reinterpret_cast<void**>(**this));
}
-template <class T>
-T* Handle<T>::operator->() const {
- return val_;
-}
-
-
-template <class T>
-T* Handle<T>::operator*() const {
- return val_;
-}
-
-
Local<Value> Arguments::operator[](int i) const {
if (i < 0 || length_ <= i) return Local<Value>(*Undefined());
return Local<Value>(reinterpret_cast<Value*>(values_ - i));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698