Issue 1219003: Store GLXFBConfig and get X visual ID from it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1219003: Store GLXFBConfig and get X visual ID from it. (Closed)

Created:
10 years, 9 months ago by Alexey Marinichev

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa

Visibility:
Public.

Description

Store GLXFBConfig and get X visual ID from it.

Patch Set 2 : Don't redeclare variables. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -57 lines)			Patch
M	client/deps/glbench/src/egl_stuff.cc	View	1	2 chunks	+31 lines, -23 lines	0 comments	Download
M	client/deps/glbench/src/glx_stuff.cc	View		2 chunks	+25 lines, -21 lines	0 comments	Download
M	client/deps/glbench/src/xlib_window.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/deps/glbench/src/xlib_window.cc	View		4 chunks	+6 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

http://codereview.chromium.org/1219003/diff/1/2 File client/deps/glbench/src/egl_stuff.cc (right): http://codereview.chromium.org/1219003/diff/1/2#newcode48 client/deps/glbench/src/egl_stuff.cc:48: EGLDisplay egl_display = eglGetDisplay(native_display); you should not re-declare the ...

10 years, 9 months ago (2010-03-24 02:43:18 UTC) #2

Alexey Marinichev

Thanks for noticing that. I wonder why compilers never warn against that. http://codereview.chromium.org/1219003/diff/1/2 File client/deps/glbench/src/egl_stuff.cc ...

10 years, 9 months ago (2010-03-24 02:49:57 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 1219003: Store GLXFBConfig and get X visual ID from it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Don't redeclare variables. #

Messages