Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: client/deps/glbench/src/glx_stuff.cc

Issue 1219003: Store GLXFBConfig and get X visual ID from it. (Closed)
Patch Set: Don't redeclare variables. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/deps/glbench/src/egl_stuff.cc ('k') | client/deps/glbench/src/xlib_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/deps/glbench/src/glx_stuff.cc
diff --git a/client/deps/glbench/src/glx_stuff.cc b/client/deps/glbench/src/glx_stuff.cc
index e350965db4513e89eac091d6a82684aa67701691..840e7e7f7bfdbad35d99a9f632d08aea02421465 100644
--- a/client/deps/glbench/src/glx_stuff.cc
+++ b/client/deps/glbench/src/glx_stuff.cc
@@ -10,6 +10,7 @@
#include "xlib_window.h"
static GLXContext glx_context = NULL;
+static GLXFBConfig glx_fbconfig = NULL;
#define F(fun, type) type fun = NULL;
LIST_PROC_FUNCTIONS(F)
@@ -19,30 +20,33 @@ bool Init() {
return XlibInit();
}
-VisualID GetVisualID() {
- int screen = DefaultScreen(g_xlib_display);
- int attrib[] = {
- GLX_DOUBLEBUFFER, True,
- GLX_RED_SIZE, 1,
- GLX_GREEN_SIZE, 1,
- GLX_BLUE_SIZE, 1,
- GLX_DEPTH_SIZE, 1,
- GLX_STENCIL_SIZE, 1,
- GLX_DRAWABLE_TYPE, GLX_WINDOW_BIT,
- None
- };
- int nelements;
- GLXFBConfig *fbconfigs = glXChooseFBConfig(g_xlib_display, screen,
- attrib, &nelements);
- CHECK(nelements >= 1);
- int visual_id;
- glXGetFBConfigAttrib(g_xlib_display, fbconfigs[0], GLX_VISUAL_ID, &visual_id);
- XFree(fbconfigs);
- return static_cast<VisualID>(visual_id);
+XVisualInfo* GetXVisual() {
+ if (!glx_fbconfig) {
+ int screen = DefaultScreen(g_xlib_display);
+ int attrib[] = {
+ GLX_DOUBLEBUFFER, True,
+ GLX_RED_SIZE, 1,
+ GLX_GREEN_SIZE, 1,
+ GLX_BLUE_SIZE, 1,
+ GLX_DEPTH_SIZE, 1,
+ GLX_STENCIL_SIZE, 1,
+ GLX_DRAWABLE_TYPE, GLX_WINDOW_BIT,
+ None
+ };
+ int nelements;
+ GLXFBConfig *fbconfigs = glXChooseFBConfig(g_xlib_display, screen,
+ attrib, &nelements);
+ CHECK(nelements >= 1);
+ glx_fbconfig = fbconfigs[0];
+ XFree(fbconfigs);
+ }
+
+ return glXGetVisualFromFBConfig(g_xlib_display, glx_fbconfig);
}
bool InitContext() {
- glx_context = glXCreateContext(g_xlib_display, g_xlib_visinfo, 0, True);
+ glx_context = glXCreateNewContext(g_xlib_display, glx_fbconfig,
+ GLX_RGBA_TYPE, 0, True);
if (!glx_context)
return false;
« no previous file with comments | « client/deps/glbench/src/egl_stuff.cc ('k') | client/deps/glbench/src/xlib_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698