Add test to check stateful partition contents

Add test to check stateful partition contents

Checks what files are on the stateful partition of a logged in user, as well as the amount of the stateful partition that's been used.

[sosa, 2010-03-25 01:30:50]

Few questions:

Should we be including directories in the whitelist?  I just checked that
re.match returns a match if you send something like re.match('/usr/bin',
'/usr/bin/tacos/blah') so I think all the dir's are matched and things like
/etc/some_file are not useful because /etc is matched.

http://codereview.chromium.org/1213005/diff/3001/4001
File client/site_tests/logging_LogVolume/control (right):

http://codereview.chromium.org/1213005/diff/3001/4001#newcode13
client/site_tests/logging_LogVolume/control:13: Tests that the metrics daemon is
running and responding to metrics addition requests.
Change doc

http://codereview.chromium.org/1213005/diff/3001/4002
File client/site_tests/logging_LogVolume/logging_LogVolume.py (right):

http://codereview.chromium.org/1213005/diff/3001/4002#newcode60
client/site_tests/logging_LogVolume/logging_LogVolume.py:60: unexpected_files =
0
Add a comment to what you mean by unexpected file i.e. non-white-listed file

http://codereview.chromium.org/1213005/diff/3001/4002#newcode64
client/site_tests/logging_LogVolume/logging_LogVolume.py:64: continue
Should we skip directories?

http://codereview.chromium.org/1213005/diff/3001/4002#newcode79
client/site_tests/logging_LogVolume/logging_LogVolume.py:79: unexpected_files)
Should we raise a test error or just report it?  Or maybe we should report perf
first then raise test error

[kmixter1, 2010-03-26 02:25:16]

PTAL

I add '$' to the end of regexps before passing them to match, so the regexps do
need to be complete.  I tried to explain that they had to be an exact match in
the comments to stateful_whitelist.txt.

http://codereview.chromium.org/1213005/diff/3001/4001
File client/site_tests/logging_LogVolume/control (right):

http://codereview.chromium.org/1213005/diff/3001/4001#newcode13
client/site_tests/logging_LogVolume/control:13: Tests that the metrics daemon is
running and responding to metrics addition requests.
On 2010/03/25 01:30:50, sosa wrote:
> Change doc

Done.

http://codereview.chromium.org/1213005/diff/3001/4002
File client/site_tests/logging_LogVolume/logging_LogVolume.py (right):

http://codereview.chromium.org/1213005/diff/3001/4002#newcode60
client/site_tests/logging_LogVolume/logging_LogVolume.py:60: unexpected_files =
0
On 2010/03/25 01:30:50, sosa wrote:
> Add a comment to what you mean by unexpected file i.e. non-white-listed file

Done.

http://codereview.chromium.org/1213005/diff/3001/4002#newcode64
client/site_tests/logging_LogVolume/logging_LogVolume.py:64: continue
On 2010/03/25 01:30:50, sosa wrote:
> Should we skip directories?

I think we should - for instance we should be aware of when new empty
directories are created.  If a month down the road this becomes a real pain to
deal with, we might want to revisit.  But I think any file system entries should
be finite and properly cleaned up.

http://codereview.chromium.org/1213005/diff/3001/4002#newcode79
client/site_tests/logging_LogVolume/logging_LogVolume.py:79: unexpected_files)
On 2010/03/25 01:30:50, sosa wrote:
> Should we raise a test error or just report it?  Or maybe we should report
perf
> first then raise test error

Made this be reported later so we get all the perf stuff back before raising the
error.

[sosa, 2010-03-26 16:35:56]

lgtm unless you wanna switch to a subclass of UITest in this CL

http://codereview.chromium.org/1213005/diff/9001/10003
File client/site_tests/logging_LogVolume/logging_LogVolume.py (right):

http://codereview.chromium.org/1213005/diff/9001/10003#newcode28
client/site_tests/logging_LogVolume/logging_LogVolume.py:28: if not
site_login.attempt_logout():
Can you make this a subclass of site_ui_test.UITest rather than test and remove
all the common login code?  You can also (or I) in another CL.  Up to you

http://codereview.chromium.org/1213005/diff/9001/10003#newcode97
client/site_tests/logging_LogVolume/logging_LogVolume.py:97: raise
error.TestFail('Coult not wait for login manager')
Change comment or if you have changed to UI Test then just let it cleanup itself

[kmixter1, 2010-03-29 17:52:14]

I switched to UITest and submitted.

On Fri, Mar 26, 2010 at 9:35 AM,  <sosa@chromium.org> wrote:
> lgtm unless you wanna switch to a subclass of UITest in this CL
>
>
> http://codereview.chromium.org/1213005/diff/9001/10003
> File client/site_tests/logging_LogVolume/logging_LogVolume.py (right):
>
> http://codereview.chromium.org/1213005/diff/9001/10003#newcode28
> client/site_tests/logging_LogVolume/logging_LogVolume.py:28: if not
> site_login.attempt_logout():
> Can you make this a subclass of site_ui_test.UITest rather than test and
> remove all the common login code?  You can also (or I) in another CL.
> Up to you
>
> http://codereview.chromium.org/1213005/diff/9001/10003#newcode97
> client/site_tests/logging_LogVolume/logging_LogVolume.py:97: raise
> error.TestFail('Coult not wait for login manager')
> Change comment or if you have changed to UI Test then just let it
> cleanup itself
>
> http://codereview.chromium.org/1213005
>