Issue 12079084: Add command line switch --enable-webrtc on Android.

Issue 12079084: Add command line switch --enable-webrtc on Android. (Closed)

Created:
7 years, 10 months ago by wjia(left Chromium)

Modified:
7 years, 10 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add command line switch --enable-webrtc on Android. WebRTC is turned off by default on Android. This flag would allow early adapters on Android to try out WebRTC. BUG=161417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179794

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

lgtm https://codereview.chromium.org/12079084/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/12079084/diff/1/content/public/common/content_switches.h#newcode44 content/public/common/content_switches.h:44: CONTENT_EXPORT extern const char kEnableWebRTC[]; nit: alpha order. ...

7 years, 10 months ago (2013-01-31 01:21:42 UTC) #2

wjia(left Chromium)

https://codereview.chromium.org/12079084/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/12079084/diff/1/content/public/common/content_switches.h#newcode44 content/public/common/content_switches.h:44: CONTENT_EXPORT extern const char kEnableWebRTC[]; On 2013/01/31 01:21:42, piman ...

7 years, 10 months ago (2013-01-31 04:42:39 UTC) #3

lgtm

Expand Messages | Collapse Messages