Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1203001: Fix board lookup code to work from any directory. (Closed)

Created:
10 years, 9 months ago by robotboy
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, ericli, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix board lookup code to work from any directory.

Patch Set 1 #

Patch Set 2 : Add double quotes for safety. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/scripts/autotest_lib.sh View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
robotboy
As a side note, in the future please avoid using bash's ${variable:number} syntax for stripping ...
10 years, 9 months ago (2010-03-23 20:52:49 UTC) #1
ericli
10 years, 9 months ago (2010-03-23 20:58:13 UTC) #2
LGTM.

Thanks for fixing this. And advice taken.

Powered by Google App Engine
This is Rietveld 408576698