Issue 1201001: Modifies image so that devs can tell immediately whether their build is a test build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1201001: Modifies image so that devs can tell immediately whether their build is a test build (Closed)

Created:
10 years, 9 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Modifies image so that devs can tell immediately whether their build is a test build

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	A	src/scripts/mod_for_test_scripts/001changeBuildName	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 9 months ago (2010-03-23 20:35:05 UTC) #2

LGTM

On Tue, Mar 23, 2010 at 1:22 PM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Modifies image so that devs can tell immediately whether their build is a
> test
> build
>
> Please review this at http://codereview.chromium.org/1201001
>
> Affected files:
>  A src/scripts/mod_for_test_scripts/001changeBuildName
>
>
> Index: src/scripts/mod_for_test_scripts/001changeBuildName
> diff --git a/src/scripts/mod_for_test_scripts/001changeBuildName
> b/src/scripts/mod_for_test_scripts/001changeBuildName
> new file mode 100755
> index
>
0000000000000000000000000000000000000000..c7ffc24151df412364260f8a8590e6f4d6999d0f
> --- /dev/null
> +++ b/src/scripts/mod_for_test_scripts/001changeBuildName
> @@ -0,0 +1,12 @@
> +#!/bin/bash
> +
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +#
> +# Changes the description of the image for test builds so that developers
> +# can tell immediately if they have a test build vs. a developer build.
> +
> +echo "Modifying Release Description for Test."
> +FILE="${ROOT_FS_DIR}/etc/lsb-release"
> +sed -i 's/Developer/Test/' $FILE
>
>
>

Expand Messages | Collapse Messages