Issue 119442: A step closer to make presubmit SCM independent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119442: A step closer to make presubmit SCM independent. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

A step closer to make presubmit SCM independent. Stop presubmit_support.py from calling gcl.GetRepositoryRoot(). Instead, save the repository root in ChangeInfo and name it GetLocalRoot() to make it less confusing. Add GetFileList() and GetFileNames() to ChangeInfo to make it less confusing and more "interface-like". TEST=updated unit tests with a lot of pain BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18266

Patch Set 1 #

Patch Set 2 : Remove crap #

Patch Set 3 : sync to trunk #

Patch Set 4 : . #

Patch Set 5 : unit tests pass #

Patch Set 6 : simplify the change #

Total comments: 1

Patch Set 7 : Rename GetFileList() to GetFiles() #

Patch Set 8 : oops #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+303 lines, -207 lines)			Patch
M	gcl.py	View	1 2 3 4 5 6 7	18 chunks	+40 lines, -29 lines	0 comments	Download
M	presubmit_support.py	View	1 2 3 4 5 6	6 chunks	+10 lines, -11 lines	0 comments	Download
M	tests/gcl_unittest.py	View	1 2 3 4 5 6	15 chunks	+58 lines, -31 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1 2 3 4 5 6	26 chunks	+195 lines, -136 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

11 years, 6 months ago (2009-06-12 01:22:09 UTC) #2

LGTM with nit

http://codereview.chromium.org/119442/diff/4002/4003
File gcl.py (right):

http://codereview.chromium.org/119442/diff/4002/4003#newcode297
Line 297: def GetFileList(self):
suggest just GetFiles

Expand Messages | Collapse Messages