A step closer to make presubmit SCM independent.

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.2'
 
@@ skipping 486 matching lines @@
   
   Instance members:
     tags: Dictionnary of KEY=VALUE pairs found in the change description.
     self.KEY: equivalent to tags['KEY']
   """
 
   # Matches key/value (or "tag") lines in changelist descriptions.
   _tag_line_re = re.compile(
       '^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$')
 
-  def __init__(self, change_info, repository_root=''):
+  def __init__(self, change_info):
     #  Do not keep a reference to the original change_info.
     self._name = change_info.name
     self._full_description = change_info.description
-    self._repository_root = repository_root
+    self._repository_root = change_info.GetLocalRoot()
     self.issue = change_info.issue
     self.patchset = change_info.patchset
 
     # From the description text, build up a dictionary of key/value pairs
     # plus the description minus all key/value or "tag" lines.
     self._description_without_tags = []
     self.tags = {}
     for line in change_info.description.splitlines():
       m = self._tag_line_re.match(line)
       if m:
         self.tags[m.group('key')] = m.group('value')
       else:
         self._description_without_tags.append(line)
 
     # Change back to text and remove whitespace at end.
     self._description_without_tags = '\n'.join(self._description_without_tags)
     self._description_without_tags = self._description_without_tags.rstrip()
 
     self._affected_files = [
-        SvnAffectedFile(info[1], info[0].strip(), repository_root)
-        for info in change_info.files
+        SvnAffectedFile(info[1], info[0].strip(), self._repository_root)
+        for info in change_info.GetFiles()
     ]
 
   def Name(self):
     """Returns the change name."""
     return self._name
 
   def DescriptionText(self):
     """Returns the user-entered changelist description, minus tags.
 
     Any line in the user-provided description starting with e.g. "FOO="
@@ skipping 101 matching lines @@
         break
   entries.sort()
   entries = map(lambda x: os.path.join(x, 'PRESUBMIT.py'), entries)
   return filter(lambda x: os.path.isfile(x), entries)
 
 
 class PresubmitExecuter(object):
   def __init__(self, change_info, committing):
     """
     Args:
-      change_info: The ChangeInfo object for the change.
+      change_info: The gcl.ChangeInfo object for the change.
       committing: True if 'gcl commit' is running, False if 'gcl upload' is.
     """
     # TODO(maruel): Determine the SCM.
-    self.change = GclChange(change_info, gcl.GetRepositoryRoot())
+    self.change = GclChange(change_info)
     self.committing = committing
 
   def ExecPresubmitScript(self, script_text, presubmit_path):
     """Executes a single presubmit script.
 
     Args:
       script_text: The text of the presubmit script.
       presubmit_path: The path to the presubmit file (this will be reported via
         input_api.PresubmitLocalPath()).
 
@@ skipping 38 matching lines @@
   """Runs all presubmit checks that apply to the files in the change.
 
   This finds all PRESUBMIT.py files in directories enclosing the files in the
   change (up to the repository root) and calls the relevant entrypoint function
   depending on whether the change is being committed or uploaded.
 
   Prints errors, warnings and notifications.  Prompts the user for warnings
   when needed.
 
   Args:
-    change_info: The ChangeInfo object for the change.
+    change_info: The gcl.ChangeInfo object for the change.
     committing: True if 'gcl commit' is running, False if 'gcl upload' is.
     verbose: Prints debug info.
     output_stream: A stream to write output from presubmit tests to.
     input_stream: A stream to read input from the user.
     default_presubmit: A default presubmit script to execute in any case.
     may_prompt: Enable (y/n) questions on warning or error.
 
   Return:
     True if execution can continue, False if not.
   """
-  checkout_root = gcl.GetRepositoryRoot()
-  presubmit_files = ListRelevantPresubmitFiles(change_info.FileList(),
-                                               checkout_root)
+  presubmit_files = ListRelevantPresubmitFiles(change_info.GetFileNames(),
+                                               change_info.local_root)
   if not presubmit_files and verbose:
     output_stream.write("Warning, no presubmit.py found.\n")
   results = []
   executer = PresubmitExecuter(change_info, committing)
   if default_presubmit:
     if verbose:
       output_stream.write("Running default presubmit script.\n")
-    fake_path = os.path.join(checkout_root, 'PRESUBMIT.py')
+    fake_path = os.path.join(change_info.local_root, 'PRESUBMIT.py')
     results += executer.ExecPresubmitScript(default_presubmit, fake_path)
   for filename in presubmit_files:
     filename = os.path.abspath(filename)
     if verbose:
       output_stream.write("Running %s\n" % filename)
     # Accept CRLF presubmit script.
     presubmit_script = gcl.ReadFile(filename, 'rU')
     results += executer.ExecPresubmitScript(presubmit_script, filename)
 
   errors = []
@@ skipping 65 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                None,
                                False)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))