Issue 119345: Use the convenience function gdk_screen_get_window_stack to enumerate top-lev...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119345: Use the convenience function gdk_screen_get_window_stack to enumerate top-lev... (Closed)

Created:
11 years, 6 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use the convenience function gdk_screen_get_window_stack to enumerate top-level gdk windows instead of querying Xlib directly, which doesn't work across many window managers. BUG=none TEST=Exhaustive tab dragging in multiple window managers (Compiz, Metacity, KWM). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18098

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -42 lines)			Patch
M	chrome/browser/dock_info_gtk.cc	View	6 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/common/gtk_util.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/common/x11_util.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/common/x11_util.cc	View	1 chunk	+5 lines, -19 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, just a question for my education. http://codereview.chromium.org/119345/diff/1/3 File chrome/common/x11_util.cc (right): http://codereview.chromium.org/119345/diff/1/3#newcode156 Line 156: if ...

11 years, 6 months ago (2009-06-09 16:37:55 UTC) #2

James Hawkins

11 years, 6 months ago (2009-06-10 21:54:23 UTC) #3

http://codereview.chromium.org/119345/diff/1/3
File chrome/common/x11_util.cc (right):

http://codereview.chromium.org/119345/diff/1/3#newcode156
Line 156: if (!XTranslateCoordinates(GetSecondaryDisplay(), window, root,
On 2009/06/09 16:37:55, tony wrote:
> What is this for?

This translates the coordinates that are window-relative to the coordinate space
of root.  Root in this case, is the root window of the WM.  So this gives us
screen coordinates for window if we don't already have them from XGetGeometry. 
This case was needed for Metacity (and probably KWM), but not for compiz, which
is why I left it out in the first iteration.

Expand Messages | Collapse Messages