Use the convenience function gdk_screen_get_window_stack to enumerate top-lev...

chrome/common/x11_util.cc

Index: chrome/common/x11_util.cc
===================================================================
--- chrome/common/x11_util.cc	(revision 17916)
+++ chrome/common/x11_util.cc	(working copy)
@@ -144,34 +144,20 @@
 }
 
 bool GetWindowRect(XID window, gfx::Rect* rect) {
-  Window root_window;
+  Window root, child;
   int x, y;
   unsigned int width, height;
   unsigned int border_width, depth;
 
-  if (!XGetGeometry(GetXDisplay(), window, &root_window, &x, &y,
+  if (!XGetGeometry(GetXDisplay(), window, &root, &x, &y,
                     &width, &height, &border_width, &depth))
     return false;
 
-  *rect = gfx::Rect(x, y, width, height);
-  return true;
-}
-
-bool EnumerateChildWindows(XID root, EnumerateWindowsDelegate* delegate) {
-  XID parent;
-  XID* children;
-  unsigned int num_children;
-  int status = XQueryTree(GetXDisplay(), root, &root, &parent,
-                          &children, &num_children);
-  if (status == 0)
+  if (!XTranslateCoordinates(GetSecondaryDisplay(), window, root,

[tony, 2009/06/09 16:37:55]

What is this for?

[James Hawkins, 2009/06/10 21:54:23]

This translates the coordinates that are window-relative to the coordinate space
of root.  Root in this case, is the root window of the WM.  So this gives us
screen coordinates for window if we don't already have them from XGetGeometry. 
This case was needed for Metacity (and probably KWM), but not for compiz, which
is why I left it out in the first iteration.

+                             0, 0, &x, &y, &child))
     return false;
 
-  for (unsigned int i = 0; i < num_children; i++) {
-    if (delegate->ShouldStopIterating(children[i]))
-      break;
-  }
-
-  XFree(children);
+  *rect = gfx::Rect(x, y, width, height);
   return true;
 }