Issue 119322: Trying to re-land r17758

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119322: Trying to re-land r17758 (Closed)

Created:
11 years, 6 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Trying to re-land r17758 (http://codereview.chromium.org/118247) but with name installer_util_unittests instead of util_unittests. BUG=12849

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+469 lines, -340 lines)			Patch
M	chrome/installer/installer.gyp	View	3 chunks	+22 lines, -4 lines	0 comments	Download
M	chrome/installer/setup/main.cc	View	3 chunks	+2 lines, -31 lines	0 comments	Download
A	chrome/installer/setup/run_all_unittests.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/installer/setup/setup.vcproj	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util_unittest.cc	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	chrome/installer/util/installer_unittests.rc	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/installer/util/installer_unittests.vcproj	View	1 chunk	+0 lines, -218 lines	0 comments	Download
M	chrome/installer/util/installer_unittests_resource.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
A	chrome/installer/util/installer_util_unittests.rc	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A	chrome/installer/util/installer_util_unittests.vcproj	View	1 chunk	+218 lines, -0 lines	0 comments	Download
A	chrome/installer/util/installer_util_unittests_resource.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/tools/test/smoketests.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/code_coverage/coverage.py	View	3 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

kuchhal

11 years, 6 months ago (2009-06-08 20:03:43 UTC) #1

There is no code change from r17758 so it is already reviewed. May be you can
look at the changes to two .py files which I added?