Issue 118247: Add project for setup unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118247: Add project for setup unittests (Closed)

Created:
11 years, 6 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
huanr, Nicolas Sylvain, bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Renamed installer_unittests to util_unittests and added setup_unitests project with only one unit test for now. BUG=12849 TEST=none Committed: http://src.chromium.org/viewvc/17758

Patch Set 1 #

Patch Set 2 : fix tab char #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+466 lines, -335 lines)			Patch
M	chrome/installer/installer.gyp	View	1	3 chunks	+22 lines, -4 lines	1 comment	Download
M	chrome/installer/setup/main.cc	View		3 chunks	+2 lines, -31 lines	0 comments	Download
A	chrome/installer/setup/run_all_unittests.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/installer/setup/setup.vcproj	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/installer/setup/setup_util_unittest.cc	View		1 chunk	+70 lines, -0 lines	0 comments	Download
M	chrome/installer/util/installer_unittests.rc	View		1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/installer/util/installer_unittests.vcproj	View		1 chunk	+0 lines, -218 lines	0 comments	Download
M	chrome/installer/util/installer_unittests_resource.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
A	chrome/installer/util/util_unittests.rc	View		1 chunk	+68 lines, -0 lines	0 comments	Download
A	chrome/installer/util/util_unittests.vcproj	View		1 chunk	+218 lines, -0 lines	0 comments	Download
A	chrome/installer/util/util_unittests_resource.h	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kuchhal

Brad, can you review installer.gyp changes? Huan, can you review everything else?

11 years, 6 months ago (2009-06-04 19:11:07 UTC) #1

bradn

LGTM on the gyp, I don't see the delete for the old vcproj name?

11 years, 6 months ago (2009-06-05 18:46:01 UTC) #3

Nicolas Sylvain

11 years, 6 months ago (2009-06-08 20:19:20 UTC) #4

Let me know when you plan to land this. early in the morning, or later at night
is best.

Nicolas

http://codereview.chromium.org/118247/diff/1001/1002
File chrome/installer/installer.gyp (right):

http://codereview.chromium.org/118247/diff/1001/1002#newcode235
Line 235: 'target_name': 'util_unittests',
installer_util maybe?

Expand Messages | Collapse Messages