Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 119318: Fix the in-progress download status in the download page for the RTL UI (Closed)

Created:
11 years, 6 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the in-progress download status for the RTL UI. 1. Make the download progress pie chart fill up CW even in the RTL UI. 2. Make the filename be at the right end instead of being in the middle of the download status in the RTL UI. BUG=13215, 13216 (http://crbug.com/13215, http://crbug.com/13216) TEST=1. Launch Chrome with --lang=he or --lang=ar. 2. Download a large file (like chrome mini-installer or Firefox) and go to the download tab (pressing Ctrl-J would work) 3. The progress pie-chart should be filled up clockwise. 4. The filename should be to the right of the download status ('5 kB of 7.2 MB - 4 mins left' in Hebrew or Arabic) instead of being put in the middle of the status string. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18022

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/resources/downloads.html View 1 4 chunks +11 lines, -5 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
11 years, 6 months ago (2009-06-09 22:51:21 UTC) #1
arv (Not doing code reviews)
LGTM
11 years, 6 months ago (2009-06-09 23:06:13 UTC) #2
jeremy
Sorry for the stupid question, but are you sure you've uploaded the right patch here?
11 years, 6 months ago (2009-06-09 23:34:35 UTC) #3
jungshik at Google
On 2009/06/09 23:34:35, jeremy wrote: > Sorry for the stupid question, but are you sure ...
11 years, 6 months ago (2009-06-10 01:15:29 UTC) #4
jeremy
http://codereview.chromium.org/119318/diff/1002/1003 File chrome/browser/resources/downloads.html (right): http://codereview.chromium.org/119318/diff/1002/1003#newcode521 Line 521: // reordering. BiDi algorithm -> The bidi Algorithm ...
11 years, 6 months ago (2009-06-10 01:21:08 UTC) #5
arv (Not doing code reviews)
LGTM Please add a link like Jeremy suggested.
11 years, 6 months ago (2009-06-10 01:23:53 UTC) #6
jungshik at Google
11 years, 6 months ago (2009-06-10 03:31:15 UTC) #7
On 2009/06/10 01:23:53, arv wrote:
> LGTM
> 
> Please add a link like Jeremy suggested.

thanks for review. I missed Jeremy's second comment (progress arc) in r18022,
which I addressed in r18023 (
http://src.chromium.org/viewvc/chrome?view=rev&revision=18023 ).

Powered by Google App Engine
This is Rietveld 408576698