Fix the in-progress download status in the download page for the RTL UI

chrome/browser/resources/downloads.html

Index: chrome/browser/resources/downloads.html
===================================================================
--- chrome/browser/resources/downloads.html	(revision 17954)
+++ chrome/browser/resources/downloads.html	(working copy)
@@ -203,6 +203,10 @@
   node.style.display = isShow ? 'inline' : 'none';
 }
 
+function showInlineBlock(node, isShow) {
+  node.style.display = isShow ? 'inline-block' : 'none';
+}
+
 /**
  * Creates an element of a specified type with a specified class name.
  * @param {String} type The node type.
@@ -511,7 +515,11 @@
     }
 
     showInline(this.nodeFileLink_, this.state_ == Download.States.COMPLETE);
-    showInline(this.nodeFileName_, this.state_ != Download.States.COMPLETE);
+    // nodeFileName_ has to be inline-block to avoid the 'interaction' with 
+    // nodeStatus_. If both are inline, it appears that their text contents
+    // are merged before BiDi algorithm is applied leading to an undesirable
+    // reordering.

[jeremy, 2009/06/10 01:21:09]

BiDi algorithm -> The bidi Algorithm

Also, could you add a link back to the bug?

+    showInlineBlock(this.nodeFileName_, this.state_ != Download.States.COMPLETE);
 
     if (this.state_ == Download.States.IN_PROGRESS) {
       this.nodeProgressForeground_.style.display = 'block';
@@ -530,9 +538,8 @@
                                Download.Progress.radius,
                                Download.Progress.base,
                                Download.Progress.base + Math.PI * 0.02 *
-                               Number(this.percent_) *
-                               (Download.Progress.dir ? -1 : 1),
-                               Download.Progress.dir);
+                               Number(this.percent_),
+                               false);

[jeremy, 2009/06/10 01:21:09]

Could you add a comment with a link back to the bug, just so people don't
reintroduce it.

 
       this.canvasProgress_.lineTo(Download.Progress.centerX,
                                   Download.Progress.centerY);
@@ -657,7 +664,6 @@
 
 function load() {
   localStrings = new LocalStrings($('l10n'));
-  Download.Progress.dir = document.documentElement.dir == 'rtl';
   downloads = new Downloads();
   $('term').focus();
   setSearch("");