Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 119304: Add log compression ability. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add log compression ability. This is a trivial per-row compression: - short aliases are introduced for events and code creation tags; - in tick events, offsets are used instead of absolute addresses; - removed 'code-allocation' event, as it seems not used. The first two options are depend on the new flag: 'compress-log', which is off by default. On benchmarks run w/o snapshot, this gives 45% log size reduction. Committed: http://code.google.com/p/v8/source/detail?r=2122

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -74 lines) Patch
M src/builtins.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/log.h View 4 chunks +43 lines, -5 lines 0 comments Download
M src/log.cc View 13 chunks +71 lines, -31 lines 2 comments Download
M src/stub-cache.cc View 26 chunks +32 lines, -26 lines 2 comments Download
M src/x64/assembler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/tickprocessor.js View 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-08 11:25:11 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/119304/diff/1/9 File src/log.cc (right): http://codereview.chromium.org/119304/diff/1/9#newcode622 Line 622: void Logger::CodeCreateEvent( I think we normally use ...
11 years, 6 months ago (2009-06-08 12:28:47 UTC) #2
Mikhail Naganov
11 years, 6 months ago (2009-06-08 13:39:08 UTC) #3
http://codereview.chromium.org/119304/diff/1/9
File src/log.cc (right):

http://codereview.chromium.org/119304/diff/1/9#newcode622
Line 622: void Logger::CodeCreateEvent(
On 2009/06/08 12:28:47, Søren Gjesse wrote:
> I think we normally use the following format for long argument lists:
> 
> void Logger::CodeCreateEvent(LogEventsAndTags tag,
>                              Code* code,
>                              const char* comment) {

OK, fixed.

http://codereview.chromium.org/119304/diff/1/11
File src/stub-cache.cc (right):

http://codereview.chromium.org/119304/diff/1/11#newcode816
Line 816: LOG(CodeCreateEvent(
On 2009/06/08 12:28:47, Søren Gjesse wrote:
> Please format this call like the others:
> 
> LOG(CodeCreateEvent(Logger::CALL_NORMAL_TAG,
>                     code, code->arguments_count()));

Done.

Powered by Google App Engine
This is Rietveld 408576698