src/stub-cache.cc - Issue 119304: Add log compression ability.

Unified Diff: src/stub-cache.cc

Issue 119304: Add log compression ability. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: src/stub-cache.cc

diff --git a/src/stub-cache.cc b/src/stub-cache.cc

index f7e5456ef85c518389e1f87fe411aed35078cb3f..f87723ed051844ae18bb9b43f9612e67b83b5913 100644

--- a/src/stub-cache.cc

+++ b/src/stub-cache.cc

@@ -103,7 +103,7 @@ Object* StubCache::ComputeLoadField(String* name,

LoadStubCompiler compiler;

code = compiler.CompileLoadField(receiver, holder, field_index, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("LoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return code;

}

@@ -122,7 +122,7 @@ Object* StubCache::ComputeLoadCallback(String* name,

LoadStubCompiler compiler;

code = compiler.CompileLoadCallback(receiver, holder, callback, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("LoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return code;

}

@@ -141,7 +141,7 @@ Object* StubCache::ComputeLoadConstant(String* name,

LoadStubCompiler compiler;

code = compiler.CompileLoadConstant(receiver, holder, value, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("LoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return code;

}

@@ -158,7 +158,7 @@ Object* StubCache::ComputeLoadInterceptor(String* name,

LoadStubCompiler compiler;

code = compiler.CompileLoadInterceptor(receiver, holder, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("LoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return code;

}

@@ -182,7 +182,7 @@ Object* StubCache::ComputeKeyedLoadField(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadField(name, receiver, holder, field_index);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -201,7 +201,7 @@ Object* StubCache::ComputeKeyedLoadConstant(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadConstant(name, receiver, holder, value);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -219,7 +219,7 @@ Object* StubCache::ComputeKeyedLoadInterceptor(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadInterceptor(receiver, holder, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -238,7 +238,7 @@ Object* StubCache::ComputeKeyedLoadCallback(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadCallback(name, receiver, holder, callback);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -256,7 +256,7 @@ Object* StubCache::ComputeKeyedLoadArrayLength(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadArrayLength(name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -273,7 +273,7 @@ Object* StubCache::ComputeKeyedLoadStringLength(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadStringLength(name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -290,7 +290,7 @@ Object* StubCache::ComputeKeyedLoadFunctionPrototype(String* name,

KeyedLoadStubCompiler compiler;

code = compiler.CompileLoadFunctionPrototype(name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedLoadIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_LOAD_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -309,7 +309,7 @@ Object* StubCache::ComputeStoreField(String* name,

StoreStubCompiler compiler;

code = compiler.CompileStoreField(receiver, field_index, transition, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("StoreIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::STORE_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -327,7 +327,7 @@ Object* StubCache::ComputeStoreCallback(String* name,

StoreStubCompiler compiler;

code = compiler.CompileStoreCallback(receiver, callback, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("StoreIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::STORE_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -344,7 +344,7 @@ Object* StubCache::ComputeStoreInterceptor(String* name,

StoreStubCompiler compiler;

code = compiler.CompileStoreInterceptor(receiver, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("StoreIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::STORE_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -361,7 +361,7 @@ Object* StubCache::ComputeKeyedStoreField(String* name, JSObject* receiver,

KeyedStoreStubCompiler compiler;

code = compiler.CompileStoreField(receiver, field_index, transition, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("KeyedStoreIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::KEYED_STORE_IC_TAG, Code::cast(code), name));

Object* result = receiver->map()->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -412,7 +412,7 @@ Object* StubCache::ComputeCallConstant(int argc,

CallStubCompiler compiler(argc);

code = compiler.CompileCallConstant(object, holder, function, check, flags);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("CallIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::CALL_IC_TAG, Code::cast(code), name));

Object* result = map->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -445,7 +445,7 @@ Object* StubCache::ComputeCallField(int argc,

CallStubCompiler compiler(argc);

code = compiler.CompileCallField(object, holder, index, name, flags);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("CallIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::CALL_IC_TAG, Code::cast(code), name));

Object* result = map->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -478,7 +478,7 @@ Object* StubCache::ComputeCallInterceptor(int argc,

CallStubCompiler compiler(argc);

code = compiler.CompileCallInterceptor(object, holder, name);

if (code->IsFailure()) return code;

- LOG(CodeCreateEvent("CallIC", Code::cast(code), name));

+ LOG(CodeCreateEvent(Logger::CALL_IC_TAG, Code::cast(code), name));

Object* result = map->UpdateCodeCache(name, Code::cast(code));

if (result->IsFailure()) return result;

}

@@ -632,7 +632,8 @@ Object* StubCache::ComputeLazyCompile(int argc) {

if (result->IsCode()) {

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("LazyCompile", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::LAZY_COMPILE_TAG,

+ code, code->arguments_count()));

}

return result;

}

@@ -780,7 +781,8 @@ Object* StubCompiler::CompileCallInitialize(Code::Flags flags) {

Counters::call_initialize_stubs.Increment();

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallInitialize", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::CALL_INITIALIZE_TAG,

+ code, code->arguments_count()));

}

return result;

}

@@ -795,7 +797,8 @@ Object* StubCompiler::CompileCallPreMonomorphic(Code::Flags flags) {

Counters::call_premonomorphic_stubs.Increment();

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallPreMonomorphic", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::CALL_PRE_MONOMORPHIC_TAG,

+ code, code->arguments_count()));

}

return result;

}

@@ -810,7 +813,8 @@ Object* StubCompiler::CompileCallNormal(Code::Flags flags) {

Counters::call_normal_stubs.Increment();

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallNormal", code, code->arguments_count()));

+ LOG(CodeCreateEvent(

Søren Thygesen Gjesse 2009/06/08 12:28:47 Please format this call like the others: LOG(Code

Mikhail Naganov 2009/06/08 13:39:09 Done.

+ Logger::CALL_NORMAL_TAG, code, code->arguments_count()));

}

return result;

}

@@ -825,7 +829,8 @@ Object* StubCompiler::CompileCallMegamorphic(Code::Flags flags) {

Counters::call_megamorphic_stubs.Increment();

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallMegamorphic", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::CALL_MEGAMORPHIC_TAG,

+ code, code->arguments_count()));

}

return result;

}

@@ -840,7 +845,7 @@ Object* StubCompiler::CompileCallMiss(Code::Flags flags) {

Counters::call_megamorphic_stubs.Increment();

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallMiss", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::CALL_MISS_TAG, code, code->arguments_count()));

}

return result;

}

@@ -854,7 +859,8 @@ Object* StubCompiler::CompileCallDebugBreak(Code::Flags flags) {

if (!result->IsFailure()) {

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallDebugBreak", code, code->arguments_count()));

+ LOG(CodeCreateEvent(Logger::CALL_DEBUG_BREAK_TAG,

+ code, code->arguments_count()));

}

return result;

}

@@ -870,7 +876,7 @@ Object* StubCompiler::CompileCallDebugPrepareStepIn(Code::Flags flags) {

if (!result->IsFailure()) {

Code* code = Code::cast(result);

USE(code);

- LOG(CodeCreateEvent("CallDebugPrepareStepIn", code,

+ LOG(CodeCreateEvent(Logger::CALL_DEBUG_PREPARE_STEP_IN_TAG, code,

code->arguments_count()));

}

return result;

« src/log.cc ('K') | « src/log.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »