Issue 119295: Add try job status check on commit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119295: Add try job status check on commit.... (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, Jói Sigurðsson

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add try job status check on commit. It acts as an advisory presubmit check for now since the try server isn't that stable. BUG=none TEST=gcl commit warns the user when a pending change hasn't passed the try job. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17870

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+45 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Tested with all success, pending, failure, no status and 404. The sad thing is that ...

11 years, 6 months ago (2009-06-08 01:45:59 UTC) #1

Nicolas Sylvain

11 years, 6 months ago (2009-06-08 17:27:33 UTC) #2

mmmm
2 seconds?

That's unfortunate.

LGTM with the nits.

http://codereview.chromium.org/119295/diff/1/2
File PRESUBMIT.py (right):

http://codereview.chromium.org/119295/diff/1/2#newcode181
Line 181: #except ValueError, e:
uh?

Expand Messages | Collapse Messages