Add try job status check on commit....

PRESUBMIT.py

 #!/usr/bin/python
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into gcl.
 """
@@ skipping 45 matching lines @@
   results.extend(LocalChecks(input_api, output_api, max_cols=0))
   results.extend(input_api.canned_checks.CheckChangeHasBugField(input_api,
                                                                 output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(input_api,
                                                                  output_api))
   # Make sure the tree is 'open'.
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api, output_api,
       'http://chromium-status.appspot.com/status', '0'
   ))
+  results.extend(CheckTryJobExecution(input_api, output_api))
   return results
 
 
 def LocalChecks(input_api, output_api, max_cols=80):
   """Reports an error if for any source file in SOURCE_FILE_EXTENSIONS:
      - uses CR (or CRLF)
      - contains a TAB
      - has a line that ends with whitespace
      - contains a line >|max_cols| cols unless |max_cols| is 0.
      - File does not end in a newline, or ends in more than one.
@@ skipping 64 matching lines @@
 
   if cr_files:
     results.append(output_api.PresubmitError(
         'Found CR (or CRLF) line ending in these files, please use only LF:',
         items=cr_files))
   if eof_files:
     results.append(output_api.PresubmitError(
         'These files should end in one (and only one) newline character:',
         items=eof_files))
   return results
+
+
+def CheckTryJobExecution(input_api, output_api):
+  url = "http://codereview.chromium.org/%d/get_build_results/%d" % (
+            input_api.change.issue, input_api.change.patchset)
+  outputs = []
+  try:
+    connection = input_api.urllib2.urlopen(url)
+    # platform|status|url
+    values = [item.split('|', 2) for item in connection.read().splitlines()]
+    connection.close()
+    statuses = map(lambda x: x[1], values)
+    if 'failure' in statuses:
+      failures = filter(lambda x: x[1] != 'success', values)
+      long_text = '\n'.join("% 5s: % 7s %s" % (item[0], item[1], item[2])
+                            for item in failures)
+      # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
+      # stable enough and it seems to work fine.
+      message = 'You had try job failures. Are you sure you want to check-in?'
+      outputs.append(output_api.PresubmitNotifyResult(message=message,
+                                                      long_text=long_text))
+    elif 'pending' in statuses or len(values) != 3:
+      long_text = '\n'.join("% 5s: % 7s %s" % (item[0], item[1], item[2])
+                            for item in values)
+      # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
+      # stable enough and it seems to work fine.
+      message = 'You should try the patch first (and wait for it to finish).'
+      outputs.append(output_api.PresubmitNotifyResult(message=message,
+                                                      long_text=long_text))
+  except input_api.urllib2.HTTPError, e:
+  #except ValueError, e:

[Nicolas Sylvain, 2009/06/08 17:27:34]

uh?

+    if e.code == 404:
+      # Fallback to no try job.
+      # TODO(maruel): Change to a PresubmitPromptWarning once the try server is
+      # stable enough and it seems to work fine.
+      outputs.append(output_api.PresubmitNotifyResult(
+          'You should try the patch first.'))
+    else:
+      # Another HTTP error happened, warn the user.
+      # TODO(maruel): Change to a PresubmitPromptWarning once it deemed to work
+      # fine.
+      outputs.append(output_api.PresubmitNotifyResult(
+          'Got %s while looking for try job status.' % str(e)))
+  return outputs