Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 119244: Add git-cl and git-try stubs. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add git-cl and git-try stubs. They automatically git clone the original repository and execute the original script. So if they are first in the path, they will be executed. If a user has another git-cl/try in the path prior, these stubs won't be used at all and won't mess with the user's setup. Also fix a bug with git handling in trychange.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17737

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A git-cl View 1 chunk +12 lines, -0 lines 1 comment Download
A git-try View 1 chunk +12 lines, -0 lines 0 comments Download
M trychange.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
Supersedes http://codereview.chromium.org/118168
11 years, 6 months ago (2009-06-05 15:28:57 UTC) #1
Evan Martin
11 years, 6 months ago (2009-06-05 18:00:19 UTC) #2
LGTM!

http://codereview.chromium.org/119244/diff/1/2
File git-cl (right):

http://codereview.chromium.org/119244/diff/1/2#newcode12
Line 12: $base_dir/git-cl-repo/git-cl $*
I think you want "$*" (with the quotes) for full correctness -- that tells the
shell to quote each arg.

Powered by Google App Engine
This is Rietveld 408576698