Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 118168: Adding git-cl and git-try as git submodules. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Adding git-cl and git-try as git submodules. Superseded by http://codereview.chromium.org/119244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A .gitmodules View 1 chunk +6 lines, -0 lines 0 comments Download
A git-cl-repo View 1 chunk +1 line, -0 lines 0 comments Download
A git-try-repo View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
I'm not sure about the empty directories it's creating in this change set. I haven't ...
11 years, 6 months ago (2009-06-03 17:15:16 UTC) #1
Evan Martin
What repo is the patch against? Is this for depot_tools?
11 years, 6 months ago (2009-06-03 17:26:07 UTC) #2
M-A Ruel
On 2009/06/03 17:26:07, Evan Martin wrote: > What repo is the patch against? Is this ...
11 years, 6 months ago (2009-06-03 17:33:17 UTC) #3
Evan Martin
On 2009/06/03 17:33:17, M-A wrote: > On 2009/06/03 17:26:07, Evan Martin wrote: > > What ...
11 years, 6 months ago (2009-06-03 17:35:10 UTC) #4
M-A Ruel
On 2009/06/03 17:35:10, Evan Martin wrote: > > It's based in depot_tools directly. > > ...
11 years, 6 months ago (2009-06-03 17:40:18 UTC) #5
Evan Martin
> > But since people check out depot_tools with svn, they won't be able to ...
11 years, 6 months ago (2009-06-03 17:44:19 UTC) #6
M-A Ruel
11 years, 6 months ago (2009-06-03 18:11:17 UTC) #7
On 2009/06/03 17:44:19, Evan Martin wrote:
> > > But since people check out depot_tools with svn, they won't be able to get
> the
> > > submodules (?)
> > 
> > People that want to use git with depot_tools are free to `git svn clone`
> > instead. I'll document that once it's tested and working. That's what I'm
> > running atm.
> 
> Hrm, we'd need to update all our instructions to tell people to do this.  And
> "git svn clone" is much slower than "svn checkout".  :\

A full clone is roughly 4 minutes here. 
git svn clone svn://svn.chromium.org/chrome/trunk/tools/depot_tools -r
17450:HEAD
is merely a few tens of seconds. Sadly, I haven't found a way to only specify
HEAD.

Updating the instructions is only for folks not already setup by themselves.

Powered by Google App Engine
This is Rietveld 408576698