Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 119116: Fix crash due to AutocompletePopup trying to draw the old results when they w... (Closed)

Created:
11 years, 6 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crash due to AutocompletePopup trying to draw the old results when they were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available. This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17562

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/notification_type.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 6 months ago (2009-06-03 22:21:18 UTC) #1
sky
11 years, 6 months ago (2009-06-03 22:56:32 UTC) #2
LGTM. Could you also update the description in notification_type.h indicate the
details.

Powered by Google App Engine
This is Rietveld 408576698