Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: chrome/browser/autocomplete/autocomplete.h

Issue 119116: Fix crash due to AutocompletePopup trying to draw the old results when they w... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 // 729 //
730 // |prefer_keyword| should be true when the keyword UI is onscreen; this will 730 // |prefer_keyword| should be true when the keyword UI is onscreen; this will
731 // bias the autocomplete results toward the keyword provider when the input 731 // bias the autocomplete results toward the keyword provider when the input
732 // string is a bare keyword. 732 // string is a bare keyword.
733 // 733 //
734 // If |synchronous_only| is true, the controller asks the providers to only 734 // If |synchronous_only| is true, the controller asks the providers to only
735 // return results which are synchronously available, which should mean that 735 // return results which are synchronously available, which should mean that
736 // all providers will be done immediately. 736 // all providers will be done immediately.
737 // 737 //
738 // The controller will fire 738 // The controller will fire
739 // NOTIFY_AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_RESULTS_AVAILABLE from inside 739 // AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_MATCHES_AVAILABLE from inside this
740 // this call, and unless the query is stopped, will fire at least one (and 740 // call, and unless the query is stopped, will fire at least one (and perhaps
741 // prehaps more) NOTIFY_AUTOCOMPLETE_CONTROLLER_RESULTS_UPDATED later as more 741 // more) AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED later as more results come in
742 // results come in (even if the query completes synchronously). 742 // (even if the query completes synchronously). Listeners should use the
743 // result set provided in the accompanying Details object to update
744 // themselves.
743 void Start(const std::wstring& text, 745 void Start(const std::wstring& text,
744 const std::wstring& desired_tld, 746 const std::wstring& desired_tld,
745 bool prevent_inline_autocomplete, 747 bool prevent_inline_autocomplete,
746 bool prefer_keyword, 748 bool prefer_keyword,
747 bool synchronous_only); 749 bool synchronous_only);
748 750
749 // Cancels the current query, ensuring there will be no future notifications 751 // Cancels the current query, ensuring there will be no future notifications
750 // fired. If new matches have come in since the most recent notification was 752 // fired. If new matches have come in since the most recent notification was
751 // fired, they will be discarded. 753 // fired, they will be discarded.
752 // 754 //
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 AutocompleteInput::Type input_type; 847 AutocompleteInput::Type input_type;
846 // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch). 848 // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch).
847 size_t selected_index; 849 size_t selected_index;
848 // Inline autocompleted length (if displayed). 850 // Inline autocompleted length (if displayed).
849 size_t inline_autocompleted_length; 851 size_t inline_autocompleted_length;
850 // Result set. 852 // Result set.
851 const AutocompleteResult& result; 853 const AutocompleteResult& result;
852 }; 854 };
853 855
854 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_ 856 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698