Issue 119017: Use a variable to control the value of LinkIncremental on Debug...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119017: Use a variable to control the value of LinkIncremental on Debug... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, Mark Mentovai

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use a variable to control the value of LinkIncremental on Debug builds, so we can force it off when building the locale .dll files. Ignore gyp-generated locales.sln file. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17394

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	build/common.gypi	View		2 chunks	+8 lines, -1 line	0 comments	Download
	M	chrome/app/locales/locales.gyp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

I'd actually rather have done this by letting 'target_defaults' in locales.gyp override the setting in ...

11 years, 6 months ago (2009-06-01 23:55:16 UTC) #1

bradn

11 years, 6 months ago (2009-06-02 00:08:08 UTC) #2

Other than that LGTM.

http://codereview.chromium.org/119017/diff/1/3
File chrome/app/locales/locales.gyp (right):

http://codereview.chromium.org/119017/diff/1/3#newcode5
Line 5: 'chrome_grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
Uh I assume you don't want to land this yet?

Expand Messages | Collapse Messages