Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: build/common.gypi

Issue 119017: Use a variable to control the value of LinkIncremental on Debug... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/locales/locales.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 17264)
+++ build/common.gypi (working copy)
@@ -50,6 +50,13 @@
# Once all vsprops settings are migrated into gyp, this can go away.
'msvs_use_common_release%': 1,
+ # TODO(sgk): eliminate this if possible.
+ # It would be nicer to support this via a setting in 'target_defaults'
+ # in chrome/app/locales/locales.gypi overriding the setting in the
+ # 'Debug' configuration in the 'target_defaults' dict below,
+ # but that doesn't work as we'd like.
+ 'msvs_debug_link_incremental%': '2',
+
# The architecture that we're building on.
'target_arch%': 'ia32',
@@ -130,7 +137,7 @@
'RuntimeLibrary': '1',
},
'VCLinkerTool': {
- 'LinkIncremental': '2',
+ 'LinkIncremental': '<(msvs_debug_link_incremental)',
},
'VCResourceCompilerTool': {
'PreprocessorDefinitions': ['_DEBUG'],
« no previous file with comments | « no previous file | chrome/app/locales/locales.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698