Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 119009: Improving the text of the cancel download dialog (Closed)

Created:
11 years, 6 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Makes the text of the in-progress download dialog better by special-casing the single download case. BUG=11278 TEST=Start a big download, close Chrome. A dialog warning that a download is in progress should be shown. Check that the main text and button text use singular when referring to the download. Start several big downloads. Close Chrome, check the text now uses plural. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +13 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 6 months ago (2009-06-01 21:47:28 UTC) #1
Glen Murphy
11 years, 6 months ago (2009-06-02 01:48:27 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698