GTK: Implement BlockedPopupContainerView for linux.

GTK: Implement BlockedPopupContainerView for linux.

This doesn't have:
- rounded corners
- gradient background
- animating in or out.
- graphical polish

but it is fucntionally complete.

http://crbug.com/12843

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18113

[tony, 2009-06-10 18:02:57]

LGTM, a few questions for my information and a couple nits.

http://codereview.chromium.org/118480/diff/15/20
File chrome/browser/browser_prefs.cc (left):

http://codereview.chromium.org/118480/diff/15/20#oldcode66
Line 66: #if defined(OS_WIN)  // TODO(port): whittle this down as we port
Woohoo!

http://codereview.chromium.org/118480/diff/15/21
File chrome/browser/gtk/blocked_popup_container_view_gtk.cc (right):

http://codereview.chromium.org/118480/diff/15/21#newcode140
Line 140: GtkWidget* padding = gtk_alignment_new(0, 0, 1, 1);
Can you use gtk_util::CreateGtkBorderBin instead of your own alignment and event
box?

http://codereview.chromium.org/118480/diff/15/21#newcode151
Line 151: kBorderPadding, kBorderPadding, kBorderPadding, kBorderPadding));
Nit: indention looks off

http://codereview.chromium.org/118480/diff/15/22
File chrome/browser/gtk/blocked_popup_container_view_gtk.h (right):

http://codereview.chromium.org/118480/diff/15/22#newcode68
Line 68: friend class BlockedPopupContainerView;
What is this needed for?  I see it's on the windows side as well.

http://codereview.chromium.org/118480/diff/15/24
File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right):

http://codereview.chromium.org/118480/diff/15/24#newcode35
Line 35: const int kScrollbarWidthHack = 25;
This is the renderer scrollbar, right?  It's hardcoded there as well so this is
fine for now :)

http://codereview.chromium.org/118480/diff/15/24#newcode374
Line 374: kScrollbarWidthHack, 0);
I suppose we always account for the scrollbar whether it is showing or not?

[Elliot Glaysher, 2009-06-10 21:52:41]

http://codereview.chromium.org/118480/diff/15/24
File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right):

http://codereview.chromium.org/118480/diff/15/24#newcode374
Line 374: kScrollbarWidthHack, 0);
On 2009/06/10 18:02:58, tony wrote:
> I suppose we always account for the scrollbar whether it is showing or not?

Yes. At least when the windows version of this code was written, there was no
way to query whether the scrollbar was showing, otherwise I'd love to do
something smarter. (There's a TODO in BPCVWin about this).

[James Hawkins, 2009-06-10 22:00:56]

LGTM