Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3575)

Unified Diff: chrome/browser/blocked_popup_container.cc

Issue 118480: GTK: Implement BlockedPopupContainerView for linux. (Closed)
Patch Set: Fix for the CreateBorderBin case. Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/blocked_popup_container.h ('k') | chrome/browser/browser_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/blocked_popup_container.cc
diff --git a/chrome/browser/blocked_popup_container.cc b/chrome/browser/blocked_popup_container.cc
index 5c35c665d70de1d88bc2bfdcd58cd466b6d2b31d..cee5b14ff00a7c84fb183c2c37b66b9da88715c2 100644
--- a/chrome/browser/blocked_popup_container.cc
+++ b/chrome/browser/blocked_popup_container.cc
@@ -17,9 +17,9 @@ BlockedPopupContainer* BlockedPopupContainer::Create(
BlockedPopupContainer* container =
new BlockedPopupContainer(owner, profile->GetPrefs());
- // TODO(erg): Add different defined(OS_??) as they get subclasses of
- // BlockedPopupContainerView.
-#if defined(OS_WIN)
+ // TODO(port): This ifdef goes away once Mac peeps write a Cocoa
+ // implementation of BlockedPopupContainerView.
+#if defined(OS_WIN) || defined(OS_LINUX)
BlockedPopupContainerView* view =
BlockedPopupContainerView::Create(container);
container->set_view(view);
@@ -180,7 +180,7 @@ void BlockedPopupContainer::RepositionBlockedPopupContainer() {
view_->SetPosition();
}
-TabContents* BlockedPopupContainer::GetTabContentsAt(size_t index) {
+TabContents* BlockedPopupContainer::GetTabContentsAt(size_t index) const {
return blocked_popups_[index].tab_contents;
}
« no previous file with comments | « chrome/browser/blocked_popup_container.h ('k') | chrome/browser/browser_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698