Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 118416: Make the CheckLongLines() less restrictive in cases where it's hard to enforce. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make the CheckLongLines() less restrictive in cases where it's hard to enforce. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17937

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 chunk +10 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-09 01:23:06 UTC) #1
Jói Sigurðsson
LGTM http://codereview.chromium.org/118416/diff/1/2 File presubmit_canned_checks.py (right): http://codereview.chromium.org/118416/diff/1/2#newcode104 Line 104: not 'http://' in line and a regexp ...
11 years, 6 months ago (2009-06-09 01:39:16 UTC) #2
M-A Ruel
11 years, 6 months ago (2009-06-09 01:44:37 UTC) #3
http://codereview.chromium.org/118416/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/118416/diff/1/2#newcode104
Line 104: not 'http://' in line and
On 2009/06/09 01:39:16, Jói wrote:
> a regexp combining all of these cases would be faster - just one scan of the
> string; but this is most likely not performance sensitive code, so fine to
> ignore for now

Yes it's slightly verbose but I thought it was more readable this way than 2
regexp.

Powered by Google App Engine
This is Rietveld 408576698