Make the CheckLongLines() less restrictive in cases where it's hard to enforce.

presubmit_canned_checks.py

 #!/usr/bin/env python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
@@ skipping 80 matching lines @@
           (f.LocalPath(), line_num))]
   return []
 
 
 def CheckLongLines(input_api, output_api, maxlen=80):
   """Checks that there aren't any lines longer than maxlen characters in any of
   the text files to be submitted.
   """
   bad = []
   for f, line_num, line in input_api.RightHandSideLines():
-    if len(line) > maxlen:
+    # Allow lines with http://, https:// and #define/#pragma/#include/#if/#endif
+    # to exceed the maxlen rule.
+    if (len(line) > maxlen and
+        not 'http://' in line and

[Jói Sigurðsson, 2009/06/09 01:39:16]

a regexp combining all of these cases would be faster - just one scan of the
string; but this is most likely not performance sensitive code, so fine to
ignore for now

[M-A Ruel, 2009/06/09 01:44:37]

Yes it's slightly verbose but I thought it was more readable this way than 2
regexp.

+        not 'https://' in line and
+        not line.startswith('#define') and
+        not line.startswith('#include') and
+        not line.startswith('#pragma') and
+        not line.startswith('#if') and
+        not line.startswith('#endif')):
       bad.append(
           '%s, line %s, %s chars' %
           (f.LocalPath(), line_num, len(line)))
       if len(bad) == 5:  # Just show the first 5 errors.
         break
 
   if bad:
     msg = "Found lines longer than %s characters (first 5 shown)." % maxlen
     return [output_api.PresubmitPromptWarning(msg, items=bad)]
   else:
@@ skipping 39 matching lines @@
     except ImportError:
       outputs.append(message_type("Failed to load %s" % unit_test,
                                   long_text=input_api.traceback.format_exc()))
 
   results = input_api.unittest.TextTestRunner(verbosity=0).run(
       input_api.unittest.TestSuite(tests_suite))
   if not results.wasSuccessful():
     outputs.append(message_type("%d unit tests failed." %
                                 (len(results.failures) + len(results.errors))))
   return outputs