Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 118226: Simplify the processing of deferred code in the code generator. Our... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Simplify the processing of deferred code in the code generator. Our deferred code snippets are highly stylized. They always make a call to a stub or the runtime and then return. This change takes advantage of that. Creating a deferred code object now captures a snapshot of the registers in the virtual frame. The registers are automatically saved on entry to the deferred code and restored on exit. The clients of deferred code must ensure that there is no change to the registers in the virtual frame (eg, by allocating which can cause spilling) or to the stack pointer. That is currently the case. As a separate change, I will add either code to verify this constraint or else code to forbid any frame effect. The deferred code itself does not use the virtual frame or register allocator (or even the code generator). It is raw macro assembler code. Committed: http://code.google.com/p/v8/source/detail?r=2112

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+766 lines, -630 lines) Patch
M src/arm/codegen-arm.cc View 12 chunks +59 lines, -79 lines 0 comments Download
A src/arm/codegen-arm-inl.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/codegen.h View 1 2 chunks +28 lines, -21 lines 0 comments Download
M src/codegen.cc View 1 chunk +31 lines, -10 lines 0 comments Download
M src/codegen-inl.h View 3 chunks +17 lines, -24 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 44 chunks +535 lines, -496 lines 0 comments Download
A src/ia32/codegen-ia32-inl.h View 1 chunk +46 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
As is this will break the x64 build. Before submitting I will fix that by ...
11 years, 6 months ago (2009-06-04 08:52:33 UTC) #1
Kasper Lund
11 years, 6 months ago (2009-06-04 10:30:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698