Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 118189: Upstream changes to run content scripts in their own world. (Closed)

Created:
11 years, 6 months ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Feng Qian
Base URL:
http://svn.webkit.org/repository/webkit/trunk/WebCore/
Visibility:
Public.

Description

Upstream changes to run content scripts in their own world.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 9

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -213 lines) Patch
M bindings/v8/ScriptController.h View 1 chunk +6 lines, -0 lines 0 comments Download
M bindings/v8/ScriptController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M bindings/v8/V8DOMMap.h View 1 2 3 3 chunks +26 lines, -1 line 0 comments Download
M bindings/v8/V8DOMMap.cpp View 1 2 3 4 13 chunks +355 lines, -212 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
Adding mike and feng.
11 years, 6 months ago (2009-06-08 20:45:56 UTC) #1
Mike Belshe
Overall, the refactoring looks good. It's unclear to me how this plugs in - I ...
11 years, 6 months ago (2009-06-09 16:26:46 UTC) #2
abarth-chromium
> It's unclear to me how this plugs in - I guess this is a ...
11 years, 6 months ago (2009-06-09 16:46:37 UTC) #3
Aaron Boodman
Can this issue be closed?
11 years, 5 months ago (2009-07-06 23:48:48 UTC) #4
abarth
11 years, 5 months ago (2009-07-07 06:16:44 UTC) #5
Done.

On Mon, Jul 6, 2009 at 4:48 PM, <aa@chromium.org> wrote:
> Can this issue be closed?
>
> http://codereview.chromium.org/118189
>

Powered by Google App Engine
This is Rietveld 408576698