Update some comments in url_request.h to clarify that once the request is del...

Update some comments in url_request.h to clarify that once the request is deleted/cancelled, the delegate should never be called again.

(The text added to URLRequest::Cancel() was copied from URLRequest::~URLRequest()).

The comment change in resource_dispatcher_host.cc is an unrelated name fix.

TEST=0
BUG=0
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17555

[wtc, 2009-06-03 14:56:04]

LGTM.  Thanks for clarifying the comments.

URLRequest is the interface between the network stack and
the Chromium browser, so its API contracts need to be
unambiguously specified.

http://codereview.chromium.org/118151/diff/1/2
File net/url_request/url_request.h (right):

http://codereview.chromium.org/118151/diff/1/2#newcode382
Line 382: // will be effectively canceled and the delegate will not have any
more
Nit: do you know what "effectively" means here?  It seems
superfluous.

Nit: can you clarify whether the delegate may have any of its
methods called *during* the Cancel() call?

Based on your change to the comment for Read() below, it seems
that you've decided that delegate methods should not be called
during the Cancel() call.

http://codereview.chromium.org/118151/diff/1/2#newcode403
Line 403: // cancelled, OnReadComplete will always be called (including if the
read
Nit: "even if" sounds better to me than "including if"...

[eroman, 2009-06-03 19:44:37]

http://codereview.chromium.org/118151/diff/1/2
File net/url_request/url_request.h (right):

http://codereview.chromium.org/118151/diff/1/2#newcode382
Line 382: // will be effectively canceled and the delegate will not have any
more
On 2009/06/03 14:56:05, wtc wrote:
> Nit: do you know what "effectively" means here?  It seems
> superfluous.
>
> Nit: can you clarify whether the delegate may have any of its
> methods called *during* the Cancel() call?

Reworded to:

"It is guaranteed that no methods of the delegate will be called after the
request has been cancelled, including during the call to Cancel itself."

> 
> Based on your change to the comment for Read() below, it seems
> that you've decided that delegate methods should not be called
> during the Cancel() call.

Correct. The instance where delegate method was being called during the Cancel()
was a bug.

http://codereview.chromium.org/118151/diff/1/2#newcode403
Line 403: // cancelled, OnReadComplete will always be called (including if the
read
On 2009/06/03 14:56:05, wtc wrote:
> Nit: "even if" sounds better to me than "including if"...

Done.

[wtc, 2009-06-03 23:10:37]

LGTM.